Fromdomain Not Honored On Outbound INVITE Request

Home » Asterisk Users » Fromdomain Not Honored On Outbound INVITE Request
Asterisk Users 4 Comments

https://issues.asterisk.org/jira/browse/ASTERISK-20841

The patch was already posted by someone but then was deleted because of guide lines. Is it really that hard to fix? Since 1.8 there is this problem but nobody seems to care about. Asterisk isnt only used with itsp who dont care about fromdomain. Or are the developers saying, we dont care about people who are using Asterisk in smaller installations?

4 thoughts on - Fromdomain Not Honored On Outbound INVITE Request

  • Thomas Rechberger wrote:

    It’s hard in the sense that someone has to figure out in chan_sip how to fix it, do so, get it tested, and also confirm it doesn’t cause any regressions. Simply committing something isn’t enough. I’d rather not break chan_sip in some other way. ^_^ Nobody has yet done this.

    That being said… this specific issue was brought up to me by a friend and I was actually going to look at it over an upcoming weekend when I
    have time. Can I guarantee it? No, but I’m going to try. That’s how much I care. Can I do this for every issue? No. I work 8+ hours a day as it is on Asterisk and also some on the weekends. So many issues, not enough time. ^_^

    Cheers,

  • Am 20.03.2014 16:07, schrieb Joshua Colp:

    That’ll be great, i would look into this myself but i have not any clue about C. But should be able to test it.

  • meanwhile i got an answer from fprior who was testing patch already.

    add this code to chan_sip.c :

    /* Allow domain to be overridden */
    if (!ast_strlen_zero(p->fromdomain))
    d = p->fromdomain;
    else /* Save for any further attempts */
    ast_string_field_set(p, fromdomain, d);

    after this one (approx. at line 13741)
    /* Allow user to be overridden */
    if (!ast_strlen_zero(p->fromuser))
    l = p->fromuser;
    else /* Save for any further attempts */
    ast_string_field_set(p, fromuser, l);

    on 11.x it should after fromname section, but i guess wont matter. Will test this soon. The code is really that simple, is it really needed to have it signed from the author?

  • Thomas Rechberger wrote:

    Modified fix is in all branches 1.8 and up. Just to give a glimpse into what I did:

    1. Went back into past versions of Asterisk to see how long stuff has been this way
    2. Looked to see if it was left out on purpose
    3. Thought about the real world implications
    4. Looked over required change
    5. Committed to all branches

    Cheers,